Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming for -oci-ta Tasks #1022

Merged
merged 1 commit into from
May 16, 2024

Conversation

zregvart
Copy link
Collaborator

We should be consistent in our naming, makes for easier manipulation via tools.

We should be consistent in our naming, makes for easier manipulation via
tools.
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lcarva
Copy link
Contributor

lcarva commented May 16, 2024

I think the naming of parameters and results should be consistent within the Task. Given that different Tasks in this repo are managed by different teams, I don't see the value in keeping such naming consistent between them. In fact, the parameters/results just look odd in the context of each Task.

We could pursue an approach where we are consistent across all the Tasks, but I'd rather tackle that as its own larger effort.

@zregvart
Copy link
Collaborator Author

I agree, it is odd that we do not follow any single naming convention. For Trusted Artifacts to be usable in a policy, we do however need some naming conventions (e.g. the results need to be named *_ARTIFACT, so at least we can have some semblance of a naming convention there.

@lcarva
Copy link
Contributor

lcarva commented May 16, 2024

Ack. From the perspective of being able to generalize the policy rules, that makes sense.

@lcarva lcarva enabled auto-merge May 16, 2024 15:36
@lcarva lcarva added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@lcarva lcarva added this pull request to the merge queue May 16, 2024
Merged via the queue into konflux-ci:main with commit 728de14 May 16, 2024
6 checks passed
@zregvart zregvart deleted the pr/normalize-ta-tasks branch May 17, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants