Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] -f option should be resolved relative to the context directory #44

Open
tetchel opened this issue Mar 31, 2021 · 3 comments
Open
Labels
bug Something isn't working

Comments

@tetchel
Copy link
Contributor

tetchel commented Mar 31, 2021

ie if you do buildah bud -f Containerfile ./my-buildah-dir then it should look for the containerfile at ./my-buildah-dir/Containerfile

for some reason, absolute paths are used https://github.com/redhat-actions/buildah-build/blob/main/src/index.ts#L61

@tetchel tetchel added the bug Something isn't working label Mar 31, 2021
@tetchel
Copy link
Contributor Author

tetchel commented Mar 31, 2021

this would be a breaking change, so maybe we can leave it as-is for now.

@tetchel tetchel added this to Backlog in Sprint 199 Apr 7, 2021
@rtaniwa rtaniwa removed this from Backlog in Sprint 199 Apr 13, 2021
@rtaniwa rtaniwa added this to Backlog in Sprint 200 Apr 13, 2021
@rtaniwa rtaniwa removed this from Backlog in Sprint 200 May 6, 2021
@rtaniwa rtaniwa added this to Blocked in Sprint 201 May 6, 2021
@rtaniwa rtaniwa moved this from Blocked to Backlog in Sprint 201 May 6, 2021
@rtaniwa rtaniwa removed this from Backlog in Sprint 201 May 31, 2021
@rtaniwa rtaniwa added this to Backlog in Sprint 202 May 31, 2021
@rtaniwa rtaniwa removed this from Backlog in Sprint 202 Jun 14, 2021
@rtaniwa rtaniwa added this to To do in Sprint 203 via automation Jun 14, 2021
@rtaniwa rtaniwa moved this from To do to Backlog in Sprint 203 Jun 14, 2021
@rtaniwa rtaniwa removed this from Backlog in Sprint 203 Jul 6, 2021
@rtaniwa rtaniwa added this to Backlog in Sprint 204 Jul 6, 2021
@divyansh42 divyansh42 removed this from Backlog in Sprint 204 Aug 2, 2021
@divyansh42 divyansh42 added this to Backlog in Sprint 205 Aug 2, 2021
@rtaniwa rtaniwa removed this from Backlog in Sprint 205 Aug 23, 2021
@tetchel
Copy link
Contributor Author

tetchel commented Oct 4, 2021

i'm moving this to 'done' because we don't have a 'wontfix' pipeline.

HarryMichal added a commit to HarryMichal/toolbox that referenced this issue Jan 10, 2022
The action does not use provided context when looking for a
Containerfile[0].

[0] redhat-actions/buildah-build#44

containers#980
HarryMichal added a commit to HarryMichal/toolbox that referenced this issue Jan 10, 2022
The action does not use provided context when looking for a
Containerfile[0].

[0] redhat-actions/buildah-build#44

containers#980
HarryMichal added a commit to HarryMichal/toolbox that referenced this issue Jan 10, 2022
The action does not use provided context when looking for a
Containerfile[0].

[0] redhat-actions/buildah-build#44

containers#981
HarryMichal added a commit to containers/toolbox that referenced this issue Jan 10, 2022
The action does not use provided context when looking for a
Containerfile[0].

[0] redhat-actions/buildah-build#44

#981
@evanshortiss
Copy link

Just got bitten by this. IIRC other actions use the behaviour described in the Issue description. I opened #123 since it would be helpful to document this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants