Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Normalize Tag Name with Lowercasing #130

Open
bduverger opened this issue Nov 13, 2023 · 1 comment
Open

[BUG] Normalize Tag Name with Lowercasing #130

bduverger opened this issue Nov 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@bduverger
Copy link

Version

redhat-actions/push-to-registry@v2

Describe the bug

The bug was introduce in redhat-actions/push-to-registry@v2.10 with this PR #94 . The problem is this GitHub action lowercase the image tag but it's not in Docker standard. It's really nice to lowercase the image name but I got issue whtn I try later to download the tag with uppercase, because it was push with lowercase. And it
https://docs.docker.com/engine/reference/commandline/tag/#extended-description

Steps to reproduce, workflow links, screenshots

With Docker CLI, if I try to push an image with a name which contains upercase, I got this message:
invalid reference format: repository name must be lowercase
But I can push an image with a tag which contains uppercases, in Docker Hub or Quay.io:

image
image

So I think the PR #94 , related to this issue, is too restrive and this GitHub action shouldn't tranform the tag to be lowercase, just the image name if needed.
image

@bduverger bduverger added the bug Something isn't working label Nov 13, 2023
@bayou-brogrammer
Copy link

in the meantime, you can use this workaround

# Workaround bug where capital letters in your GitHub username make it impossible to push to GHCR.
      # https://github.com/macbre/push-to-ghcr/issues/12
      - name: Lowercase Registry
        id: registry_case
        uses: ASzc/change-string-case-action@v6
        with:
          string: ${{ env.IMAGE_REGISTRY }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants