Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page request fired twice when using bundleData #986

Open
salehhamadeh opened this issue Mar 8, 2018 · 0 comments
Open

Page request fired twice when using bundleData #986

salehhamadeh opened this issue Mar 8, 2018 · 0 comments

Comments

@salehhamadeh
Copy link
Contributor

When using the bundleData prop with react-server's Link, any subsequent requests to that page in the same history stack will have an unnecessary XHR page request.

Repro steps:

  1. Run react-server-test-pages
  2. Go to http://localhost:3000/navigation/data-bundle-cache
  3. Click Go. This has bundleData=true
  4. Refresh the page

Expected: When you refresh the page, there should be no XHR like this http://localhost:3000/navigation/data-bundle-cache?page=7&_react_server_data_bundle=1
Actual: The unnecessary XHR is fired.

This issue does not happen if you open a new tab and go to the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant