Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO if OSX && key is.Meta? #981

Open
Qoyyuum opened this issue Jan 8, 2018 · 0 comments
Open

TODO if OSX && key is.Meta? #981

Qoyyuum opened this issue Jan 8, 2018 · 0 comments

Comments

@Qoyyuum
Copy link
Contributor

Qoyyuum commented Jan 8, 2018

Not sure what I make of this but to clean up the TODO notes, please see if this issue can be resolved.

_onClick(e) {

		// TODO: if OSX && key.isMeta?
		if (!e.metaKey) {
			e.preventDefault();
			e.stopPropagation();
			const {bundleData, reuseDom} = this.props;
			navigateTo(this.props.path || this.props.href, {
				bundleData,
				reuseDom,
			});
			if (this.props.onClick) {
				this.props.onClick(e);
			}
		} else {
			// do normal browser navigate
		}
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant