Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator-react-server] Attempts to copy .eslintrc which doesn't always exist #967

Open
negativetwelve opened this issue Oct 25, 2017 · 0 comments

Comments

@negativetwelve
Copy link
Contributor

Hi there,

I recently created #966 which fixes one issue with using the generator-react-server package locally rather than globally.

The other issue seems to be this line https://github.com/redfin/react-server/blob/master/packages/generator-react-server/package.json#L51 which assumes we're installing from within the monorepo. In our case, we're installing generator-react-server both without the rest of the monorepo, and we're not installing it globally.

Running npm install or yarn install will run the prepublish step which tries to copy a file that doesn't exist.

Skipping the prepublish step and not having the file will result in an error with the generator because it requires that file to exist and be copied over.

Any ideas what I can do to get around this? Would love to submit a PR that solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant