Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when choosing invalid metric names #569

Open
spladug opened this issue Mar 1, 2021 · 1 comment
Open

Warn when choosing invalid metric names #569

spladug opened this issue Mar 1, 2021 · 1 comment
Labels
good starter A good place to start devving on baseplate.py observability

Comments

@spladug
Copy link
Contributor

spladug commented Mar 1, 2021

If a span is named something that doesn't make a valid metric path component, it can cause the metrics related to it to get discard. For example, a redis pipeline named foo:bar would cause a metric like clients.redis.pipeline_foo:bar which is invalid. This should not fail silently.
@spladug spladug added good starter A good place to start devving on baseplate.py observability labels Mar 1, 2021
@rishabhRsinghvi
Copy link

@spladug is it still left to be done? 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good starter A good place to start devving on baseplate.py observability
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spladug @rishabhRsinghvi