Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge implementation duplication #94

Open
phenomnomnominal opened this issue Nov 15, 2022 · 1 comment
Open

Edge implementation duplication #94

phenomnomnominal opened this issue Nov 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@phenomnomnominal
Copy link
Contributor

Describe the bug

As part of the performance improvements done to handle many edges, we had to introduce a split implementation. There is one for a small number of edges which can have animations, and one for a large number of edges which cannot have animations.

The current high perf implementation can either have animations or allow adding and removing nodes. Right now, the whole mesh is recreated when the list of nodes changes, so animating between the two sets of vertex positions is all over the place. Having both would require changing the implementation so that the mesh vertex indices remain stable as nodes are added/removed.

Steps to Reproduce the Bug or Issue

Look at the code

Expected behavior

One implementation for Egde

Screenshots or Videos

No response

Platform

  • Reagraph Version: [e.g. 1.0.0]
  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • NodeJS version: ...

Your Example Website or App

No response

Additional context

No response

@amcdnl amcdnl added the enhancement New feature or request label Jan 16, 2023
@amcdnl
Copy link
Member

amcdnl commented May 8, 2023

This could potentially be useful: https://www.npmjs.com/package/@react-three/drei#performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants