RCOCOA-2285: Wire up the new progress notifications #8492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealmSwift/Sync.swift
Outdated
|
|
||
| Whenever the progress reporting mode is `forCurrentlyOutstandingWork`, that value | ||
| will monotonically increase until it reaches 1.0. If the progress mode is `reportIndefinitely`, the | ||
| value will monotonically increase until it reaches 1.0, but may subsequently decrease if new server data |
There was a problem hiding this comment.
What happens if there is a download/upload while another download/upload happens?, wouldn't that mean that in some cases the value will not increase monotonically?
There was a problem hiding this comment.
Hm.. good question, I'll try and investigate this.
nirinchev
force-pushed
the
ni/progress-notifications
branch
2 times, most recently
from
2c4e1ff
to
bec6712
Compare
nirinchev
changed the base branch from
master
to
ni/master+tg-app-services-split
nirinchev
force-pushed
the
ni/progress-notifications
branch
from
f7c035b
to
3be4e19
Compare
nirinchev
changed the base branch from
ni/master+tg-app-services-split
to
tg/app-services-split
nirinchev
force-pushed
the
ni/progress-notifications
branch
from
f02a75a
to
45667bf
Compare
dianaafanador3
approved these changes
May 1, 2024
|
The CI failures seem to be github related (502s). |
tgoyne
reviewed
May 1, 2024
tgoyne
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a branch that is the result of merging #8539 and master. Will rebase once #8539 is merged. It depends on an unreleased Core version, so most of the workflows will fail.
Fixes #8476