Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer ad close button is obscured by scrollbar #6044

Closed
davidism opened this issue Aug 6, 2019 · 6 comments
Closed

Fixed footer ad close button is obscured by scrollbar #6044

davidism opened this issue Aug 6, 2019 · 6 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug Design Design or UX/UI related

Comments

@davidism
Copy link

davidism commented Aug 6, 2019

The floating ad has an "X" close link, but it is overlapped by the scrollbar. This happens on at least Firefox 68 and Chromium 76.

Firefox example

Chromium example

@davidism davidism changed the title Scrollbar overlaps floating ad close button Fixed footer ad close button is obscured by scrollbar Aug 6, 2019
@stsewd stsewd added Bug A bug Design Design or UX/UI related labels Aug 6, 2019
@lepture
Copy link

lepture commented Sep 3, 2019

For https://docs.authlib.org/ it breaks the theme.

image

@stale
Copy link

stale bot commented Oct 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Oct 18, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Oct 18, 2019
@lepture
Copy link

lepture commented Nov 7, 2019

@stsewd is there a way to define where the ad should be placed?

@davidism
Copy link
Author

davidism commented Nov 7, 2019

According to https://docs.readthedocs.io/en/stable/advertising/ad-customization.html, a special div id will be replaced.

<div id="ethical-ad-placement"></div>

@davidfischer thought this might disable the floating ad, but I haven't tried it yet.

@humitos
Copy link
Member

humitos commented Nov 25, 2021

@davidfischer is this still an issue? I'm not sure if we are still serving text-ads.

@davidfischer
Copy link
Contributor

We are not serving text-only ads currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug Design Design or UX/UI related
Projects
None yet
Development

No branches or pull requests

5 participants