Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.5 support for build system #1990

Closed
pohmelie opened this issue Feb 12, 2016 · 34 comments
Closed

python 3.5 support for build system #1990

pohmelie opened this issue Feb 12, 2016 · 34 comments
Labels
Improvement Minor improvement to code

Comments

@pohmelie
Copy link

Since build system use cpython 3.4 I can't build documentation for my 3.5 only project. https://readthedocs.org/projects/aioftp/builds/3722703
Is there some plans about 3.5?

@jakirkham
Copy link
Contributor

+1

@agjohnson
Copy link
Contributor

Python 3.5 will definitely come with the april ubuntu 16.04 release, we haven't discussed an interim plan -- though installing from the deadsnakes ppa could be an easy path forward. Another option is to use conda

@agjohnson agjohnson added Needed: design decision A core team decision is required Improvement Minor improvement to code labels Feb 12, 2016
@ian-ross
Copy link

ian-ross commented Mar 8, 2016

+1 from me too: https://readthedocs.org/projects/django-tutelary/builds/3795496/ (problem caused by yield from in my case).

@agjohnson
Copy link
Contributor

Conda support can target python 3.5, that might be the best bet.

@jakirkham
Copy link
Contributor

I expect there will be the same situation when Python 3.6 comes around too. So, using conda seems reasonable for this problem.

@AndreLouisCaron
Copy link

On many Linux distros and on OSX, multiple versions of Python are often aliased to python3.4, python3.5, etc.

Can't we add an option in to select one of these? We can keep the "CPython 2.x" and "CPython 3.x" options, but add "CPython 2.7", "CPython 3.4" and "CPython 3.5" in the choices too.

@agronholm
Copy link
Contributor

+1, whatever solution works :) I have plenty of 3.5 only projects coming that I'd like to build docs for.

@evertheylen
Copy link

If people are too lazy to set up a conda environment; just use this configuration file: http://stackoverflow.com/a/36144269/2678118

@agronholm
Copy link
Contributor

Question: how am I supposed to get the project installed in the conda environment?

@agjohnson
Copy link
Contributor

We could use some help beta testing ubuntu 16.04 builders, which will include python 3.5. If anyone is interested, we're collecting a handful of testers here:

https://docs.google.com/forms/d/1YHBXN8LI2RTq6ujV0zENAExtJwbNLja0QKJUHyfUvrE/viewform

@algorys
Copy link

algorys commented Jul 29, 2016

+1 for my project too. For https://readthedocs.org/projects/pycmake/builds/4247460/

Problems appears with import enum and typed parameters def foo(param: MyObj)

@AndreLouisCaron
Copy link

AndreLouisCaron commented Jul 29, 2016

FWIW, I now host my docs for Python 3.5 projects on Python Hosted solely because of this issue, but the flow there is manual, error prone and doesn't easily allow me to host docs for multiple versions, which is really annoying. I'd really appreciate if this were fixed...

Let me know if there's anything I can do to help.

@jakirkham
Copy link
Contributor

Does the answer given by @evertheylen not work for you @AndreLouisCaron?

@AndreLouisCaron
Copy link

Sorry, must has missed that email! Will try it ASAP :-)

André

On Fri, Jul 29, 2016 at 10:43 AM, jakirkham notifications@github.com
wrote:

Does the answer
#1990 (comment)
given by @evertheylen https://github.com/evertheylen not work for you
@AndreLouisCaron https://github.com/AndreLouisCaron?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1990 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAITJivVxiGEL5VJTNtuxXM8iJZxTwl5ks5qahGRgaJpZM4HZAZX
.

@numberoverzero
Copy link

Any update? I filled out the beta testing form above but haven't heard back.

@c-bata
Copy link

c-bata commented Dec 7, 2016

+1 my project uses typing module. So autodoc doesn't work :-(

@benjaminweb
Copy link

My docs are built without autodoc statements due to lack of Python 3.5:

ImportError: cannot import name 'gcd'

https://docs.python.org/3/library/math.html#math.gcd

What's the timeline?

@pohmelie
Copy link
Author

I think it's time to support 3.6, since f-strings will be "syntax error" even for 3.5.

@agjohnson agjohnson mentioned this issue Jan 5, 2017
@ashwin31
Copy link

👍

5 similar comments
@jagadeeshv16
Copy link

+1

@druuu
Copy link

druuu commented Jan 10, 2017

+1

@chaitu210
Copy link

👍

@vidyasagar-r
Copy link

vidyasagar-r commented Jan 10, 2017

👍

@ghost
Copy link

ghost commented Jan 10, 2017

👍

@udduu
Copy link

udduu commented Jan 10, 2017

👍

@agronholm
Copy link
Contributor

I'm helping the RTD staff create a better build image that allows for selecting the preferred Python version for the build. Python 3.5 and 3.6 are already included.

@vineeshan
Copy link

👍

1 similar comment
@nikhila05
Copy link

👍

@agronholm
Copy link
Contributor

You can stop the reactions now, it's distracting and does not really help.

@agjohnson
Copy link
Contributor

Just a quick update here, as I'm pushing out some updates this week.

First, through a pile of work, support for non-system Python versions has been added. The new beta build container image is now ready for testing (readthedocs/readthedocs-docker-images#18). This will support versions: 2.7, 3.3, 3.4, 3.5, and 3.6. This image uses pyenv to install multiple versions of Python, instead of relying on the distribution's versions.

This will be the new beta image going forward. If you'd like to continue testing our beta images, or would like support for python 3.6, be sure to sign up here:
https://goo.gl/forms/ai9u6jpIhpEpmMRx1

If you've been looking for python 3.5 support, and have not been added to the beta list, we are going to be switching over everyone this week to an image with python 3.5 support. You shouldn't need to do anything, but adding a readthedocs.yml file specifying the correct python version might help if you run into problems.

I am going to write up some docs on using the feature tonight, we'll be announcing changes later this week.

@c-bata
Copy link

c-bata commented Feb 14, 2017

Great updates! I've just signed up the beta support for python3.6. 👍

@humitos
Copy link
Member

humitos commented Mar 2, 2017

This issue was create to support Python 3.5 and it was added in the readthedocs/build:2.0 image so I think the work on this issue is already done and working properly (I saw many projects using python3.5 without problem).

Shouldn't we close this one and move the discussion regarding Python 3.6 to another one?

@humitos humitos closed this as completed May 29, 2017
@humitos humitos removed the Needed: design decision A core team decision is required label May 29, 2017
@Granitosaurus
Copy link

For anyone who ends up here for py3.6 support it's officially available:
http://blog.readthedocs.com/python-36-support/

TL;DR:
create file readthedocs.yaml with contents in your project root:

build:
    image: latest

python:
    version: 3.6

@RichardLitt
Copy link
Member

I wonder if there is a place in the documentation to include this note from @Granitosaurus. @humitos What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests