Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allauth: update to use latest version #11309

Open
stsewd opened this issue May 1, 2024 · 2 comments · May be fixed by #11327
Open

Allauth: update to use latest version #11309

stsewd opened this issue May 1, 2024 · 2 comments · May be fixed by #11327
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented May 1, 2024

What's the problem this feature will solve?

The latest versions of allauth include some improvements and fixes related to SAML, which is a feature we are active developing for .com.

Last time I saw that were some breaking changes related to templates, and changes around using json fields.

Additional context

The last time we updated allauth (#11134) we hit only one problem I think, it was related to a missing changelog entry about a field change in google. Another problem we had we about the settings, but that wasn't related to allauth itself, but to our settings inheritance.

@stsewd stsewd added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels May 1, 2024
@stsewd stsewd self-assigned this May 1, 2024
@humitos
Copy link
Member

humitos commented May 2, 2024

latest versions of allauth include some improvements and fixes related to SAML

What are those improvements and fixes? Knowing that will help us to work on prioritization of this upgrade.

@stsewd
Copy link
Member Author

stsewd commented May 2, 2024

You can just check the changelog and look for "SAML" https://docs.allauth.org/en/latest/release-notes/recent.html Some important ones are:

  • SAML: accessing the SLS/ACS views using a GET request would result in a crash (500).
  • SAML: the login view did not obey the SOCIALACCOUNT_LOGIN_ON_GET = False setting.

@stsewd stsewd linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants