Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Highlight issue, when migrated to latest 2.0.0 it become #424

Open
ajay9889 opened this issue May 23, 2021 · 4 comments
Open

Highlight issue, when migrated to latest 2.0.0 it become #424

ajay9889 opened this issue May 23, 2021 · 4 comments

Comments

@ajay9889
Copy link

In 2.0.0-beta.1 it was not the issue. But, when migrated it reappears the issue upon migrating to 2.0.0.

Before adding the highlights in the database, the highlight was working fine: Please refer to below screen. It is correctly placed when adding into the Highlight database.

Screenshot_1621741567

But, when clicking and navigating from the highlight list it is getting in the wrong place.

Screenshot_1621741586

@mickael-menu
Copy link
Member

I can't reproduce this issue in r2-testapp-kotlin, did you?

@ajay9889
Copy link
Author

ajay9889 commented Jun 3, 2021

No, the highlight issue is still there in the test app also when are using our ePub book in which has the chapter link. Kindly see the recorded video. Please check the actual root cause so that we can fix it as we have lined up a pilot launch.

device-2021-06-02-150136.1.mp4
device-2021-06-02-150436.1.mp4

Epub Book:

nck_epub.zip

@mickael-menu
Copy link
Member

@ajay9889 I'm sorry but I don't have any time planned for the current highlights implementation, you will need to find a workaround or a bugfix yourself.

@parsakhosravani
Copy link

Just add this code in line 66 of the highlight.js file

document.addEventListener("DOMContentLoaded", function(event) { setScrollMode(false); });

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants