Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated mode blocks reading a book on Windows at least #45

Open
manuellagrand opened this issue Jun 14, 2019 · 21 comments
Open

Paginated mode blocks reading a book on Windows at least #45

manuellagrand opened this issue Jun 14, 2019 · 21 comments
Assignees

Comments

@manuellagrand
Copy link

reading is blocked after few pages in paginated mode (approximatively 2 pages) depending on the os that is used.
with MacOS and Ubuntu 16.04 no problem, but on Windows 10 and Ubuntu 18.04 the reader doesn't work like it should.

@llemeurfr llemeurfr changed the title Paginated mode block the read Paginated mode blocks reading a book on Windows at least Jun 14, 2019
@danielweck
Copy link
Member

What is the exact source / build of the app (develop branch, or prebuilt installer?) I need to see/check the precise navigator version in package-lock.json to make sure the Electron/Chromium fix for left-right arrow keys is included.

@manuellagrand
Copy link
Author

the source is develop branch and navigator version is 1.0.26

@panaC
Copy link
Member

panaC commented Jun 14, 2019

Hello,

I think this issue is related to a second display glitch

On reader :

image

When I lower the height of the window, then I raise it to the same height as before.

image

image

That display the previous "page" of book and not the same.

I think we can lost the postion in book.

What do you think ?


Ubuntu lts 18.04
r2-navigator in 1.0.26

@llemeurfr
Copy link

To narrow down the problem, is there some log we could add to the software, so we can check something?

@danielweck
Copy link
Member

I am not able to reproduce this on Windows 10.

@danielweck
Copy link
Member

PS: I am using the develop branch (well, this actually: edrlab/thorium-reader#323 )

@manuellagrand
Copy link
Author

the paginated mode issue seems fixed on Windows 10.
Now, it's the scrollable mode on Windows 10 that blocked book reading.
I am using the develop branch

@panaC
Copy link
Member

panaC commented Jun 20, 2019

On ubuntu lts 18, it's opposite of the Manuel answer.

Paginated mode is blocked at each new chapter
whereas it doesn't blocked in scrollable mode

@danielweck
Copy link
Member

I cannot reproduce (scroll or paginated) on Linux (Lubuntu 18.04)

@danielweck
Copy link
Member

I test with various EPUBs, usual suspects: Wasteland, AccessibleEPUB3, ChildrensLitterature ...
What EPUBs are problematic in your tests?

@danielweck
Copy link
Member

Regarding "loosing the reading location": yes, this is a problem we had in Readium1 as well. Because we track the upper-left corner of the document text in order to estimate the user's reading position, when the window is resized there is a side effect of "walking backwards". Note that we also track the reading location when the user interacts with the mouse or keyboard in the document, but this isn't related.

@danielweck
Copy link
Member

I posted a separate issue: #43

@panaC
Copy link
Member

panaC commented Jun 20, 2019

@manuellagrand
Copy link
Author

@danielweck
Copy link
Member

https://bibliothequenumerique.tv5monde.com/download/epub/470
=>
504 Gateway Time-out - nginx

@panaC
Copy link
Member

panaC commented Jun 20, 2019

daniel.tar.gz

@danielweck
Copy link
Member

Dumas - Le Comte de Monte Cristo-37.epub => works fine too in my tests (scroll and paginated)

@panaC
Copy link
Member

panaC commented Jun 20, 2019

It's works now. I just removed and added the epub.
Sorry for the inconvenience

@danielweck
Copy link
Member

No problems. Weird though!

@danielweck
Copy link
Member

On MacOS I have observed a pagination bug (CSS Columns) which sounds very similar to this! When I shring the window to a smaller size, there comes a threshold point at which the reported number of columns/spreads is completely wrong (usually a very small number). It is easy to see in debug/development mode (npm run start:dev) thanks to the verbose console messages coming from the navigator (Locator notifications). Very strange bug. I suspect this is a weird edge case with Chromium-in-Electron (not the first one, not the last one ... :( )

@panaC
Copy link
Member

panaC commented Jul 1, 2019

Sorry but finally I still have this issue.
The behavior is very strange on all epub that I check. (include le comte de monte cristo).
When i click on the arrow in reader. inevitably it hangs

@llemeurfr llemeurfr transferred this issue from edrlab/thorium-reader Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants