Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard tab into detail/summary broken #32

Open
danielweck opened this issue Feb 4, 2019 · 8 comments
Open

keyboard tab into detail/summary broken #32

danielweck opened this issue Feb 4, 2019 · 8 comments

Comments

@danielweck
Copy link
Member

See:
focus-trap/tabbable#36

@danielweck
Copy link
Member Author

Note that opening/collapsing the detail element potentially results in fewer or more pages/extent in the paginated/scrolled views, so the "resize sensor" triggers and we ensure that a "reading location" notification is emitted in order to provide a refreshed calculation of offsets, etc.

@danielweck
Copy link
Member Author

danielweck commented Feb 8, 2019

Update: no-change in the external lib, for valid reasons (I agree with the library developer).
So, suggested move: fork his code, and customize to meet our needs. We have the luxury of being "limited" to the Chromium browser engine, so we can make reliable predictions about the level of support for detail/summary in terms of their focusability / tab-ability.
See:
https://allyjs.io/data-tables/focusable.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant