Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies through jcenter #31

Open
stevenzeck opened this issue May 15, 2021 · 4 comments
Open

Dependencies through jcenter #31

stevenzeck opened this issue May 15, 2021 · 4 comments
Labels
blocked external Issue blocked by a third-party dependency enhancement New feature or request

Comments

@stevenzeck
Copy link
Contributor

stevenzeck commented May 15, 2021

The jcenter() repository was originally going to be completely unavailable starting early 2022, but that has since changed in that it will now be read only indefinitely. See https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/. However, that means that existing dependencies won't be getting updates through it. Here are the dependencies all of the modules use that are only available through jcenter:

  1. com.github.barteksc:android-pdf-viewer: Used in the Navigator module. According to the readme, they're actively looking for a new maintainer, so unless someone picks it up I also don't expect it to be moved from jcenter.
    2. com.shopgun.android:utils: Used in the Navigator module. Only used in one file, R2FXLLayout, so maybe this can be replaced natively?
    3. com.duolingo.open:rtl-viewpager: Used in the Navigator module. This is no longer maintained and should be replaced by ViewPager2.
@mickael-menu mickael-menu transferred this issue from readium/r2-testapp-kotlin Oct 21, 2021
@mickael-menu mickael-menu added the enhancement New feature or request label Oct 21, 2021
@mickael-menu
Copy link
Member

1 is tricky, but could be made less critical by extracting the PDF navigator into a dedicated module. This work was started in #67.

2 and 3 will not be part of Navigator 2, so it will sort itself out.

@stevenzeck
Copy link
Contributor Author

Really need to take a hard look at this sooner than later...

@mickael-menu
Copy link
Member

For reference, regarding today's incident: https://status.gradle.com/incidents/c65zmfw32lpm

@qnga
Copy link
Contributor

qnga commented Jan 11, 2024

A fork of android-pdf-viewer has been published on Maven Central. It will be worth a look if we can solve the incompatibility between liblcp and recent versions of PDFium. As liblcp development has started again, a new hope has risen!

@qnga qnga added the blocked external Issue blocked by a third-party dependency label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked external Issue blocked by a third-party dependency enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants