Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6.1] Pointing to minified react causes warning #430

Closed
agos opened this issue May 15, 2017 · 3 comments · Fixed by #433
Closed

[4.6.1] Pointing to minified react causes warning #430

agos opened this issue May 15, 2017 · 3 comments · Fixed by #433

Comments

@agos
Copy link

agos commented May 15, 2017

Issue description

Upon upgrading from 4.5.0 to 4.6.1, a new warning pops up in console:

reactstrap.min.js:1 Warning: It looks like you're using a minified copy of the development build of React. When deploying React apps to production, make sure to use the production build which skips development warnings and is faster. See https://fb.me/react-minification for more details.

I was not able to fork the suggested pen to reproduce the issue, likely due to #429.

@Skaronator
Copy link

same as #429

@jameschao
Copy link

@Skaronator - thanks it definitely seems related.

But what I don't understand is that the package.json change you referenced (5461049) seems to be present for 4.5.0 already according to the tag list for that commit. But this current React warning wasn't there for 4.5.0 for me.

@eddywashere
Copy link
Member

fixed in 4.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants