Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2467): keyboard support for dropdown listbox #2584

Conversation

illiteratewriter
Copy link
Member

@illiteratewriter illiteratewriter commented Jul 27, 2022

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronmars
Copy link
Collaborator

aaronmars commented Aug 11, 2022

@illiteratewriter
Copy link
Member Author

@aaronmars I didn't get the question

@aaronmars
Copy link
Collaborator

Sorry, I meant to link to Dropdown.js, line 341:
https://github.com/reactstrap/reactstrap/blob/master/src/Dropdown.js#L341

Just wondering if the context vs. props issue is present there as well.

@illiteratewriter
Copy link
Member Author

That context is just to figure out if the Dropdown is wrapped inside an InputGroup. That one will be empty unless you wrap an InputGroup around the Dropdown. That works as expected.

@aaronmars
Copy link
Collaborator

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants