Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toast header #2343

Merged
merged 2 commits into from Oct 26, 2021
Merged

Fix toast header #2343

merged 2 commits into from Oct 26, 2021

Conversation

krnlde
Copy link
Contributor

@krnlde krnlde commented Oct 21, 2021

Solves ToastHeader charCode console error as described in #2338

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses Bootstrap 5 ToastHeader: charCode warning #2338
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I just removed the dangling charCode property from the defaultProps.

Closes #2338

@krnlde
Copy link
Contributor Author

krnlde commented Oct 21, 2021

Here's the new PR @phwebi

X-Ref: #2339

@phwebi phwebi merged commit e98c9e9 into reactstrap:bootstrap5 Oct 26, 2021
phwebi pushed a commit that referenced this pull request Oct 27, 2021
@krnlde
fix(ToastHeader): Remove charCode default property. (#2343)
9a3f8e9 
Fixes #2338

Co-authored-by: Kai Dorschner <me@krnl.de>
phwebi pushed a commit that referenced this pull request Oct 27, 2021
@krnlde @phwebi
fix(ToastHeader): Remove charCode default property. (#2343)
03bbd15 
Fixes #2338

Co-authored-by: Kai Dorschner <me@krnl.de>
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
This was referenced Mar 29, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phwebi phwebi phwebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krnlde @phwebi