Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): remove extra close icon in btn-close #2318

Merged
merged 1 commit into from Sep 27, 2021
Merged

Conversation

phwebi
Copy link
Member

@phwebi phwebi commented Sep 27, 2021

The close icon is now included automatically in Bootstrap 5. See https://getbootstrap.com/docs/5.1/components/close-button/#example

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phwebi phwebi merged commit f1289c7 into bootstrap5 Sep 27, 2021
@phwebi phwebi deleted the fix-btn-close branch September 27, 2021 23:25
phwebi added a commit that referenced this pull request Oct 27, 2021
phwebi added a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant