New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Jumbotron): Remove Jumbotron component #2118
refactor(Jumbotron): Remove Jumbotron component #2118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of removing this component actually. We should definitely leave an example of how to create the jumbotron in the docs though.
We kept it in an effort to avoid breaking changes, but if that's not a concern, we can definitely just remove it 👍 |
Feel free to make breaking changes. Now's a good time as any :) |
c6ba619
to
18ded26
Compare
18ded26
to
faaac80
Compare
The jumbtron and jumbotron-fluid classes have been removed in bootstrap 5.
This change emulates a similar style by using the utility classes. The padding is not exactly a 1-to-1 replacement since the jumbotron x and y paddings did not follow the utility classes styling.This PR removes the jumbotron component. This is a breaking change, so we should add instructions on how to mimic a jumbotron in the upgrade documentation. (The oldjumbotron
class can be replaced withrounded px-3 px-sm-4 py-3 py-sm-5
.jumbotron-fluid
can be replaced withbg-light mb-4 py-3 py-sm-5
)Related to: #1748