Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Jumbotron): Remove Jumbotron component #2118

Conversation

phwebi
Copy link
Member

@phwebi phwebi commented Feb 18, 2021

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The jumbtron and jumbotron-fluid classes have been removed in bootstrap 5. This change emulates a similar style by using the utility classes. The padding is not exactly a 1-to-1 replacement since the jumbotron x and y paddings did not follow the utility classes styling. This PR removes the jumbotron component. This is a breaking change, so we should add instructions on how to mimic a jumbotron in the upgrade documentation. (The old jumbotron class can be replaced with rounded px-3 px-sm-4 py-3 py-sm-5. jumbotron-fluid can be replaced with bg-light mb-4 py-3 py-sm-5)

Related to: #1748

Copy link
Member

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of removing this component actually. We should definitely leave an example of how to create the jumbotron in the docs though.

@phwebi
Copy link
Member Author

phwebi commented Feb 18, 2021

We kept it in an effort to avoid breaking changes, but if that's not a concern, we can definitely just remove it 👍

@kyletsang
Copy link
Member

Feel free to make breaking changes. Now's a good time as any :)

@phwebi phwebi force-pushed the feat(bs5)-replace-jumbotron-classes-with-utility-classes branch 2 times, most recently from c6ba619 to 18ded26 Compare February 18, 2021 23:13
@phwebi phwebi force-pushed the feat(bs5)-replace-jumbotron-classes-with-utility-classes branch from 18ded26 to faaac80 Compare February 18, 2021 23:23
@phwebi phwebi changed the title feat(bs5): Replace jumbotron classes with utility classes refactor(Jumbotron): Remove Jumbotron component Feb 18, 2021
@kyletsang kyletsang merged commit 970dfda into reactstrap:bootstrap5 Feb 19, 2021
phwebi pushed a commit that referenced this pull request Oct 27, 2021
phwebi pushed a commit that referenced this pull request Oct 27, 2021
@github-actions github-actions bot mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants