Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(bs5) change .close to .btn close #2116

Conversation

phwebi
Copy link
Member

@phwebi phwebi commented Feb 18, 2021

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR changes close to btn-close per Bootstrap 5 changes. Bootstrap 5 no longer supports custom close icons, so this feature was removed from ModalHeader and ToastHeader.

Related to: #1748

@phwebi phwebi changed the base branch from master to bootstrap5 February 18, 2021 20:12
@kyletsang kyletsang merged commit 0cdc1ce into reactstrap:bootstrap5 Feb 19, 2021
phwebi pushed a commit that referenced this pull request Mar 5, 2021
* feat(bs5): Change classname from .close to .btn-close for Button

* feat(bs5): Change button classname from .close to .btn-close for ModalHeader

* feat(bs5): Change button classname from .close to .btn-close for Alert

* feat(bs5): Change button classname from .close to .btn-close for ToastHeader

* don't render extra close icon for alerts, modal/toast headers

Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi pushed a commit that referenced this pull request Aug 27, 2021
* feat(bs5): Change classname from .close to .btn-close for Button

* feat(bs5): Change button classname from .close to .btn-close for ModalHeader

* feat(bs5): Change button classname from .close to .btn-close for Alert

* feat(bs5): Change button classname from .close to .btn-close for ToastHeader

* don't render extra close icon for alerts, modal/toast headers

Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi pushed a commit that referenced this pull request Sep 9, 2021
* feat(bs5): Change classname from .close to .btn-close for Button

* feat(bs5): Change button classname from .close to .btn-close for ModalHeader

* feat(bs5): Change button classname from .close to .btn-close for Alert

* feat(bs5): Change button classname from .close to .btn-close for ToastHeader

* don't render extra close icon for alerts, modal/toast headers

Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi pushed a commit that referenced this pull request Sep 16, 2021
* feat(bs5): Change classname from .close to .btn-close for Button

* feat(bs5): Change button classname from .close to .btn-close for ModalHeader

* feat(bs5): Change button classname from .close to .btn-close for Alert

* feat(bs5): Change button classname from .close to .btn-close for ToastHeader

* don't render extra close icon for alerts, modal/toast headers

Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi pushed a commit that referenced this pull request Oct 27, 2021
* feat(bs5): Change classname from .close to .btn-close for Button

* feat(bs5): Change button classname from .close to .btn-close for ModalHeader

* feat(bs5): Change button classname from .close to .btn-close for Alert

* feat(bs5): Change button classname from .close to .btn-close for ToastHeader

* don't render extra close icon for alerts, modal/toast headers

Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi pushed a commit that referenced this pull request Oct 27, 2021
* feat(bs5): Change classname from .close to .btn-close for Button

* feat(bs5): Change button classname from .close to .btn-close for ModalHeader

* feat(bs5): Change button classname from .close to .btn-close for Alert

* feat(bs5): Change button classname from .close to .btn-close for ToastHeader

* don't render extra close icon for alerts, modal/toast headers

Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants