New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(bs5) change .close to .btn close #2116
Merged
kyletsang
merged 5 commits into
reactstrap:bootstrap5
from
gthomas-appfolio:feat(bs5)-Change-.close-to-.btn-close
Feb 19, 2021
Merged
Feat(bs5) change .close to .btn close #2116
kyletsang
merged 5 commits into
reactstrap:bootstrap5
from
gthomas-appfolio:feat(bs5)-Change-.close-to-.btn-close
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
approved these changes
Feb 19, 2021
phwebi
pushed a commit
that referenced
this pull request
Mar 5, 2021
* feat(bs5): Change classname from .close to .btn-close for Button * feat(bs5): Change button classname from .close to .btn-close for ModalHeader * feat(bs5): Change button classname from .close to .btn-close for Alert * feat(bs5): Change button classname from .close to .btn-close for ToastHeader * don't render extra close icon for alerts, modal/toast headers Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi
pushed a commit
that referenced
this pull request
Aug 27, 2021
* feat(bs5): Change classname from .close to .btn-close for Button * feat(bs5): Change button classname from .close to .btn-close for ModalHeader * feat(bs5): Change button classname from .close to .btn-close for Alert * feat(bs5): Change button classname from .close to .btn-close for ToastHeader * don't render extra close icon for alerts, modal/toast headers Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi
pushed a commit
that referenced
this pull request
Sep 9, 2021
* feat(bs5): Change classname from .close to .btn-close for Button * feat(bs5): Change button classname from .close to .btn-close for ModalHeader * feat(bs5): Change button classname from .close to .btn-close for Alert * feat(bs5): Change button classname from .close to .btn-close for ToastHeader * don't render extra close icon for alerts, modal/toast headers Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi
pushed a commit
that referenced
this pull request
Sep 16, 2021
* feat(bs5): Change classname from .close to .btn-close for Button * feat(bs5): Change button classname from .close to .btn-close for ModalHeader * feat(bs5): Change button classname from .close to .btn-close for Alert * feat(bs5): Change button classname from .close to .btn-close for ToastHeader * don't render extra close icon for alerts, modal/toast headers Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi
pushed a commit
that referenced
this pull request
Oct 27, 2021
* feat(bs5): Change classname from .close to .btn-close for Button * feat(bs5): Change button classname from .close to .btn-close for ModalHeader * feat(bs5): Change button classname from .close to .btn-close for Alert * feat(bs5): Change button classname from .close to .btn-close for ToastHeader * don't render extra close icon for alerts, modal/toast headers Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
phwebi
pushed a commit
that referenced
this pull request
Oct 27, 2021
* feat(bs5): Change classname from .close to .btn-close for Button * feat(bs5): Change button classname from .close to .btn-close for ModalHeader * feat(bs5): Change button classname from .close to .btn-close for Alert * feat(bs5): Change button classname from .close to .btn-close for ToastHeader * don't render extra close icon for alerts, modal/toast headers Co-authored-by: Swaraj Patel <swarajpatel37@gmail.com>
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
close
tobtn-close
per Bootstrap 5 changes. Bootstrap 5 no longer supports custom close icons, so this feature was removed fromModalHeader
andToastHeader
.Related to: #1748