Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(bs5) accordion #2105

Merged
merged 6 commits into from Feb 24, 2021
Merged

Feat(bs5) accordion #2105

merged 6 commits into from Feb 24, 2021

Conversation

phwebi
Copy link
Member

@phwebi phwebi commented Feb 18, 2021 •
edited

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR adds the new Accordion feature introduced in Bootstrap 5 and updates the minimum react version to 16.8.0 in order to support hooks.

Related to: #1748

kyletsang
kyletsang requested changes Feb 21, 2021
View reviewed changes
src/Accordion.js Outdated Show resolved Hide resolved
src/AccordionBody.js Show resolved Hide resolved
docs/lib/routes.js Show resolved Hide resolved
src/AccordionBody.js Outdated Show resolved Hide resolved
src/Accordion.js Outdated Show resolved Hide resolved
kyletsang
kyletsang reviewed Feb 22, 2021
View reviewed changes
src/AccordionBody.js Outdated Show resolved Hide resolved
@phwebi
Copy link
Member Author

phwebi commented Feb 22, 2021 •
edited

Thanks for reviewing btw! (I force pushed since I had to rebase to get the updated bootstrap version for testing my changes)

kyletsang
kyletsang requested changes Feb 23, 2021
View reviewed changes
docs/lib/Components/AccordionPage.js Outdated Show resolved Hide resolved
types/lib/AccordionBody.d.ts Outdated Show resolved Hide resolved
@kyletsang
Copy link
Member

Thanks for reviewing btw! (I force pushed since I had to rebase to get the updated bootstrap version for testing my changes)

No problem! I think a couple more changes and it should be good to go.

@kyletsang kyletsang merged commit 115d204 into reactstrap:bootstrap5 Feb 24, 2021
@Madhukar-singh
Copy link

Madhukar-singh commented Mar 4, 2021 •
edited

I am not able to export Accordion what should i have to update to use Accordion not able to get this using yarn while installing ?
is this available in yarn or not

@phwebi
Copy link
Member Author

phwebi commented Mar 4, 2021

Hi @singhmadhukar11 ! The Accordion is part of the bootstrap 5 branch that hasn't been officially released yet. We do have a pre-release version 9.0.0-0 if you want to test it out.

@Madhukar-singh
Copy link

Hi @singhmadhukar11 ! The Accordion is part of the bootstrap 5 branch that hasn't been officially released yet. We do have a pre-release version 9.0.0-0 if you want to test it out.

Hey @phwebi thanks for information. If this is the part of bootstrap 5 then why i able to see on website yet if you not released 9.0.0-0 version.
Because of this develop will be confused.

@phwebi
Copy link
Member Author

phwebi commented Mar 4, 2021

Oh - we had a hiccup with the release bot tagging the prerelease as our latest version. We fixed that, but didn't realize the website was updated. We need to revert that as well. Thanks for the heads up!

phwebi added a commit that referenced this pull request Mar 5, 2021
@phwebi
feat(bs5): add accordion (#2105)
37839c6 
* feat(bs5): add accordion

* chore(dep): upgrade react to 16.8.0

* refactor(accordion): use uceContext hook

* refactor(AccordionBody): change id to accordionId

* refactor(AccordionBody): make Tag only affect accordion-body element

* feature(Accordion): add UncontrolledAccordion
phwebi added a commit that referenced this pull request Aug 27, 2021
@phwebi
feat(bs5): add accordion (#2105)
41a6b4e 
* feat(bs5): add accordion

* chore(dep): upgrade react to 16.8.0

* refactor(accordion): use uceContext hook

* refactor(AccordionBody): change id to accordionId

* refactor(AccordionBody): make Tag only affect accordion-body element

* feature(Accordion): add UncontrolledAccordion
phwebi added a commit that referenced this pull request Sep 9, 2021
@phwebi
feat(bs5): add accordion (#2105)
c25025e 
* feat(bs5): add accordion

* chore(dep): upgrade react to 16.8.0

* refactor(accordion): use uceContext hook

* refactor(AccordionBody): change id to accordionId

* refactor(AccordionBody): make Tag only affect accordion-body element

* feature(Accordion): add UncontrolledAccordion
phwebi added a commit that referenced this pull request Sep 16, 2021
@phwebi
feat(bs5): add accordion (#2105)
8b561e6 
* feat(bs5): add accordion

* chore(dep): upgrade react to 16.8.0

* refactor(accordion): use uceContext hook

* refactor(AccordionBody): change id to accordionId

* refactor(AccordionBody): make Tag only affect accordion-body element

* feature(Accordion): add UncontrolledAccordion
phwebi added a commit that referenced this pull request Oct 27, 2021
@phwebi
feat(bs5): add accordion (#2105)
559dc7f 
* feat(bs5): add accordion

* chore(dep): upgrade react to 16.8.0

* refactor(accordion): use uceContext hook

* refactor(AccordionBody): change id to accordionId

* refactor(AccordionBody): make Tag only affect accordion-body element

* feature(Accordion): add UncontrolledAccordion
phwebi added a commit that referenced this pull request Oct 27, 2021
@phwebi
feat(bs5): add accordion (#2105)
1c09448 
* feat(bs5): add accordion

* chore(dep): upgrade react to 16.8.0

* refactor(accordion): use uceContext hook

* refactor(AccordionBody): change id to accordionId

* refactor(AccordionBody): make Tag only affect accordion-body element

* feature(Accordion): add UncontrolledAccordion
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phwebi @kyletsang @Madhukar-singh