From cbcb2e3abc240f64833967996cce4c4878529170 Mon Sep 17 00:00:00 2001 From: Phoebe Gao Date: Fri, 30 Oct 2020 15:10:36 -0700 Subject: [PATCH] feat(bs5): replace form-group class with mb-3 --- docs/lib/Components/FormPage.js | 2 +- src/FormGroup.js | 2 +- src/__tests__/FormGroup.spec.js | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/lib/Components/FormPage.js b/docs/lib/Components/FormPage.js index 1c7d66b64..352027239 100644 --- a/docs/lib/Components/FormPage.js +++ b/docs/lib/Components/FormPage.js @@ -117,7 +117,7 @@ FormGroup.propTypes = { children: PropTypes.node, // Applied the row class when true, does nothing when false row: PropTypes.bool, - // Applied the form-check class when true, form-group when false + // Applied the form-check class when true, mb-3 when false check: PropTypes.bool, inline: PropTypes.bool, // Applied the disabled class when the check and disabled props are true, does nothing when false diff --git a/src/FormGroup.js b/src/FormGroup.js index 6829825b8..25f7eeb9f 100644 --- a/src/FormGroup.js +++ b/src/FormGroup.js @@ -33,7 +33,7 @@ const FormGroup = (props) => { const classes = mapToCssModules(classNames( className, row ? 'row' : false, - check ? 'form-check' : 'form-group', + check ? 'form-check' : 'mb-3', check && inline ? 'form-check-inline' : false, check && disabled ? 'disabled' : false ), cssModule); diff --git a/src/__tests__/FormGroup.spec.js b/src/__tests__/FormGroup.spec.js index 8cd809788..5750afa82 100644 --- a/src/__tests__/FormGroup.spec.js +++ b/src/__tests__/FormGroup.spec.js @@ -15,10 +15,10 @@ describe('FormGroup', () => { expect(wrapper.text()).toBe('Yo!'); }); - it('should render with "form-group" class by default', () => { + it('should render with "mb-3" class by default', () => { const wrapper = shallow(Yo!); - expect(wrapper.hasClass('form-group')).toBe(true); + expect(wrapper.hasClass('mb-3')).toBe(true); }); it('should not render with "form-check" nor "form-check-inline" class by default', () => { @@ -53,10 +53,10 @@ describe('FormGroup', () => { expect(wrapper.hasClass('form-check-inline')).toBe(false); }); - it('should not render with "form-group" class when check prop is truthy', () => { + it('should not render with "mb-3" class when check prop is truthy', () => { const wrapper = shallow(Yo!); - expect(wrapper.hasClass('form-group')).toBe(false); + expect(wrapper.hasClass('mb-3')).toBe(false); }); it('should not render with "disabled" class when disabled prop is truthy but check is not', () => {