fix(Offcanvas): make types match existing direction prop

reactstrap · May 27, 2022 · 6e60f08 · 6e60f08
1 parent 5d3eedf
commit 6e60f08
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Offcanvas.js b/src/Offcanvas.js
@@ -29,7 +29,7 @@ const propTypes = {
   className: PropTypes.string,
   container: targetPropType,
   cssModule: PropTypes.object,
-  direction: PropTypes.oneOf(['start', 'end', 'bottom', 'top', 'left', 'right']),
+  direction: PropTypes.oneOf(['start', 'end', 'bottom', 'top']),
   fade: PropTypes.bool,
   innerRef: PropTypes.oneOfType([PropTypes.object, PropTypes.string, PropTypes.func,]),
   isOpen: PropTypes.bool,

diff --git a/types/lib/Offcanvas.d.ts b/types/lib/Offcanvas.d.ts
@@ -2,7 +2,7 @@ import * as React from 'react';
 import { CSSModule } from './utils';
 import { FadeProps } from './Fade';
 
-export type Placement = 'start' | 'end' | 'left' | 'right' | 'bottom' | 'top';
+export type Direction = 'start' | 'end' | 'bottom' | 'top';
 
 export interface OffcanvasProps extends React.HTMLAttributes<HTMLElement> {
   [key: string]: any;
@@ -24,7 +24,7 @@ export interface OffcanvasProps extends React.HTMLAttributes<HTMLElement> {
   onEnter?: () => void;
   onExit?: () => void;
   onOpened?: () => void;
-  placement?: Placement;
+  direction?: Direction;
   returnFocusAfterClose?: boolean;
   scrollable?: boolean;
   toggle?: React.KeyboardEventHandler<any> | React.MouseEventHandler<any>;