From c20fa9397ea09811ed2b4da33b136f2aa1e98957 Mon Sep 17 00:00:00 2001 From: illiteratewriter Date: Sat, 21 May 2022 21:47:19 +0530 Subject: [PATCH 1/2] fix(#2393): captions visible twice --- src/CarouselIndicators.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CarouselIndicators.js b/src/CarouselIndicators.js index 2eb1c9ddd..71bc383cf 100644 --- a/src/CarouselIndicators.js +++ b/src/CarouselIndicators.js @@ -6,6 +6,7 @@ import { mapToCssModules } from './utils'; const CarouselIndicators = (props) => { const { items, activeIndex, cssModule, onClickHandler, className } = props; + const listClasses = mapToCssModules(classNames(className, 'carousel-indicators'), cssModule); const indicators = items.map((item, idx) => { const indicatorClasses = mapToCssModules(classNames( @@ -22,7 +23,6 @@ const CarouselIndicators = (props) => { }} className={indicatorClasses} > - {item.caption} ); }); From 1b4f845a955e707d5ec45cf0dc9a5c520c1186ba Mon Sep 17 00:00:00 2001 From: illiteratewriter Date: Fri, 27 May 2022 10:47:30 +0530 Subject: [PATCH 2/2] close button in itself --- src/CarouselIndicators.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/CarouselIndicators.js b/src/CarouselIndicators.js index 71bc383cf..4b9c8a373 100644 --- a/src/CarouselIndicators.js +++ b/src/CarouselIndicators.js @@ -6,7 +6,6 @@ import { mapToCssModules } from './utils'; const CarouselIndicators = (props) => { const { items, activeIndex, cssModule, onClickHandler, className } = props; - const listClasses = mapToCssModules(classNames(className, 'carousel-indicators'), cssModule); const indicators = items.map((item, idx) => { const indicatorClasses = mapToCssModules(classNames( @@ -22,8 +21,7 @@ const CarouselIndicators = (props) => { onClickHandler(idx); }} className={indicatorClasses} - > - ); + />); }); return (