Fix Change NavigationStack as DataMember #3379
Conversation
|
I am unsure if this build error is my fault or not |
I will try to check it this evening to see what's happening, thank you |
FrameworkDisplayName=".NET 6.0" does not reflect the same value on Github FrameworkDisplayName="" is returned instead
Codecov ReportBase: 63.60% // Head: 63.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3379 +/- ##
=======================================
Coverage 63.60% 63.60%
=======================================
Files 157 157
Lines 5768 5768
=======================================
Hits 3669 3669
Misses 2099 2099
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
glennawatson
changed the title
|
Sooner they fix that problem so we can remove those ugly workarounds the better. |
Agree, I will keep an eye on it |
| @@ -47,7 +47,7 @@ public RoutingState(IScheduler? scheduler = null) | |||
| /// Gets the current navigation stack, the last element in the | |||
| /// collection being the currently visible ViewModel. | |||
| /// </summary> | |||
| [IgnoreDataMember] | |||
| [DataMember] | |||
| public ObservableCollection<IRoutableViewModel> NavigationStack { get; } | |||
There was a problem hiding this comment.
Not sure if just changing [IgnoreDataMember] to [DataMember] fixes the issue #3322. According to L42, the NavigationStack property is only initialized inside the constructor and offers no public setter for a serializer.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #3322