Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autocomplete prop #949

Open
ad1992 opened this issue Apr 23, 2024 · 1 comment
Open

Remove autocomplete prop #949

ad1992 opened this issue Apr 23, 2024 · 1 comment

Comments

@ad1992
Copy link
Member

ad1992 commented Apr 23, 2024

Currently, we have an autocomplete prop to decide whether to add suggestions irrespective of whether they are selected.
It was added in #39 and has the below behaviour

- `true` - when the delimiter key (such as enter) is pressed, the first matching suggestion is used.
- `1` - when the delimiter key (such as enter) is pressed, the matching suggestion is used only if there is a single matching suggestion
- `false` (default) - tags are not autocompleted on enter/delimiter

As you can see it allows adding tags without selecting them when set to true and when setting the value to 1 it will allow adding only when there is one matching suggestion.

These behaviours are very specific to the host app and not intuitive as well. We should allow adding tags only when explicitly selected and hence will be removing this prop in 7.x

To ease the above process, we can introduce a new prop may be which decides whether to auto select the first matching suggestion when typing.

Thoughts welcome :) 🙏🏻

@ad1992
Copy link
Member Author

ad1992 commented Apr 23, 2024

cc @rnicholus, would like to know your thoughts too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant