Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press events no longer propagating to children after Expo 49 upgrade #750

Open
abelfiore opened this issue Sep 15, 2023 · 1 comment
Open
Labels

Comments

@abelfiore
Copy link

Environment

System:
OS: macOS 13.5
CPU: (8) arm64 Apple M1
Memory: 546.69 MB / 16.00 GB
Shell:
version: 3.2.57
path: /bin/bash
Binaries:
Node:
version: 16.4.0
path: ~/.nvm/versions/node/v16.4.0/bin/node
Yarn: Not Found
npm:
version: 7.18.1
path: ~/.nvm/versions/node/v16.4.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.11.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10671973
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.16.1
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.4
wanted: 0.72.4
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false

Platforms

iOS, not sure about Android yet

Versions

  • Android:
  • iOS: 16.6.1
  • react-native-modal: 13.0.1
  • react-native: 0.72.4
  • react: 18.2.0

Description

After upgrading to Expo 49, Modal no longer propagating press events to the children components. I swapped out the react-native-modal Modal with the react native Modal and the press events are working again.

Reproducible Demo

@abelfiore abelfiore added the bug label Sep 15, 2023
@bnert
Copy link

bnert commented Dec 14, 2023

I've experienced something similar on React Native 0.72.7, and the latest, when putting a react-navigation stack navigator in a modal. The only resolutions were:

  • Break out navigation items to use presentation: "modal" (seems more idiomatic)
  • Downgrade to a specific set of versions for react-navigation and react-native-screens. Don't know the exact versions off the top of my head.

I'm hoping the above is useful, and maybe relevant? If not, then freely ignore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants