Trying to collaborate

[andra961]

Hi everyone!This would be my first contribution to a community package and i'm having trouble to understand the workflow which would lead to a pull request. I forked the repository, then cloned it in a folder inside my project where i'd like to test the changes i will make. Once cloned i do a npm install inside the forked repo and then npm run build. The problem is that during the build i get lots of error TS1005: ';' expected and error TS1005: '=' expected. My plan if the build had success would have been to make changes in the .ts files, build again through build command and so on until i commit. Have i understand correctly the process?if not could you point out where i misunderstood?thx in advance

[mmazzarolo]

Hi Andra! :)
Unfortunately I can't pull down the repo and give it a test, but the flow I recommend using for working on this repo is available in the CONTRIBUTING.md documentation 👍 Let me know how it goes.

[andra961]

Yeah unfortunately i still get those errors when i try to build with typescript. I'm sure i'm using the local version in the node modules which i installed with npm install...

[andra961]

I get this error when i build:

src/modal.tsx:538:35 - error TS2339: Property 'includes' does not exist on type 'Direction[]'.

538       ? this.props.swipeDirection.includes(direction)

When i run the example android app i get no stack error

[mmazzarolo]

Are you sure you're using the right version of TS? (meaning the one included in the project:

react-native-modal/package.json

Line 78 in d0bf96b

"typescript": "3.7.2"

)

[andra961]

Yes i even tried to run it directly from node_modules

…

Are you sure you're using the right version of TS? (meaning the one included in the project: https://github.com/react-native-modal/react-native-modal/blob/d0bf96bfe84f2227820b9d8086a79e0781c0c385/package.json#L78 ) — Reply to this email directly, view it on GitHub <#668 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGHNA337K5DFKBJW44MYFFTVIDLPLANCNFSM5UZVICZQ> . You are receiving this because you authored the thread.Message ID: <react-native-modal/react-native-modal/repo-discussions/668/comments/2678519 @github.com>

[andra961]

Did you install dependencies using yarn ?

No i used npm but it should be the same. Later i can try with yarn too. But can you please answer a question(i'm trying to learn)?so the contributing flow would be testing changes i make to the package in the example app, i get it. But what if i'd like to instead testing them on my existing app before committing?would i have to copy paste the cloned repo in my app root folder and just import it like this: "import Modal from "../react-native-modal/index/index.js"?

[ancyrweb]

You might want to check yarn link or equivalent npm link method, whose purpose is to enable development of packages. Since we are using yarn with a lockfile that holds the exact version numbers, you should use it to work on the project.

[andra961]

You might want to check yarn link or equivalent npm link method, whose purpose is to enable development of packages. Since we are using yarn with a lockfile that holds the exact version numbers, you should use it to work on the project.

Tried with yarn too but i get the same error above unfortunately :(

[ancyrweb]

It looks like your installation is incorrect, try to delete the node_modules entirely and install from yarn. Eventually clear yarn cache ?

[andra961]

It looks like your installation is incorrect, try to delete the node_modules entirely and install from yarn. Eventually clear yarn cache ?

Tried it many times with both npm and yarn, also resetting cache, same error. Which version of node are you using, also which OS?i have node 14.15.4 on Windows