Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悰] Issue picking image from synced with iCloud #2220

Open
jefflewis opened this issue Sep 25, 2023 · 7 comments 路 May be fixed by #2221
Open

[馃悰] Issue picking image from synced with iCloud #2220

jefflewis opened this issue Sep 25, 2023 · 7 comments 路 May be fixed by #2221

Comments

@jefflewis
Copy link

Description

A device in iOS 16 that captures a photo and syncs to iCloud Photo Library that an iOS 17 app selects with this library fails the check for PHPhotoPicker when loading it he UIImage class.

I plan to fix this in our app, patch the library and submit a PR.

Explain the bug in as much detail as possible

How to repeat issue and example

  • see description

Solution

What needs to be done to address this issue?

I will update the API to use the item for identifier instead of data for class.

Additional Information

  • Image Picker version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.]
  • React Native version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.]
  • Platform: [FILL THIS OUT: iOS, Android, or both?]
  • Development Operating System: [FILL THIS OUT: Are you developing on MacOS, Linux, or Windows?]
  • Dev tools: [FILL THIS OUT: Xcode or Android Studio version, iOS or Android SDK version, if applicable] navigation crash for Android
@jefflewis jefflewis changed the title [馃悰] [馃悰] Issue picking image from synced with iCloud Sep 28, 2023
@mglobel
Copy link

mglobel commented Sep 28, 2023

Hi @jefflewis thank you so much for opening this issue. I think our users have been reporting this issue and we've frustratingly been unable to reproduce.

Is there any workaround for users, like unsyncing the image? Also would you be able to share your patch? We may need to do an emergency release as well until there's a PR that's been merged.

@jefflewis
Copy link
Author

I can reproduce and am adding a PR for this library shortly.

jefflewis added a commit to xoeye/react-native-image-picker that referenced this issue Sep 29, 2023
* Preserve metadata for images when targeting JPEG output
* Fixes react-native-image-picker#2220 - continue picker if only available format is HEIF or HEIC
@jefflewis jefflewis linked a pull request Sep 29, 2023 that will close this issue
4 tasks
@GunnarAK
Copy link

I'm experiencing a similar issue with videos saved to the user's iPhone from other apps, such as WhatsApp.

@mglobel perhaps this helps in reproducing the issue on your end?

  1. Open WhatsApp and select a chat
  2. Scroll to a video
  3. Press and hold for the options menu
  4. Select 'Save' to save it to the iPhone's general storage.
  5. Open your React Native app and select the video file with the RNImagePicker component.

@GunnarAK
Copy link

It appears this has been fixed in 7.1.0 for me.

I'm using USE_FRAMEWORKS static to install pods in my project.

PR #2242 that includes the fix for 7.1.0

@Manikandan-saminathan
Copy link

USE_FRAMEWORKS static
@GunnarAK Can you explain in a bit more detail how to use this fix?.I am not able to find any additional steps mentioned in docs

@GunnarAK
Copy link

GunnarAK commented Apr 25, 2024

@Manikandan-saminathan it is dependent on your project. In my case I'm using RNFirebase, which requires me to configure the project to use static frameworks.

See https://rnfirebase.io/#altering-cocoapods-to-use-frameworks

That's what was causing the issue with this module for me, hence my previous comment.

If static frameworks dont ring a bell, it probably doesnt apply to you. Good luck

@MANIKANDAN1709
Copy link

@Manikandan-saminathan it is dependent on your project. In my case I'm using RNFirebase, which requires me to configure the project to use static frameworks.

See https://rnfirebase.io/#altering-cocoapods-to-use-frameworks

That's what was causing the issue with this module for me, hence my previous comment.

If static frameworks dont ring a bell, it probably doesnt apply to you. Good luck

@Johan-dutoit @GunnarAK case I am using the react native image picker to select the images if ios device photos app sync to iCloud option was enabled the device shows the images captured in other devices.Not full images are downloaded I think the thumbnail only downloaded when I try edit the images in photos app it was asking me to download the image.When I select those image use react native image picker I am getting the Url of those image but when try copy to my app specific directory using react native blob utils library I getting the error image not found at the location. How can fix this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants