New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working in Firefox #869
Comments
React-dnd does work however in Firefox 55.0.2. |
not working in 56.0 either, no errors thrown. Simply unable to click and drag at all. works fine in Chrome |
Any ideas on this one? Firefox: 56.0 |
can someone point to a repository with a sample case in which react-dnd is failing? i have an app that uses react-dnd a lot but i don't see any problem in firefox 56. also please make sure to specify the OS that you are using, i have seen that recently html5 Drag and Drop API is having some inconsistencies in different OS |
I've observed issues with FF 56 on Linux, as well (didn't test on Windows or OSX). http://react-dnd.github.io/react-dnd/examples-sortable-simple.html Trying that simple example, an element will move at max 1 position and then no longer shift elements, if for example, I grab the bottom element and try to move it up to the top. Also discussed in #778 |
…newer Firefox versions and potential other browsers as well
For our case - DnD not working in FF, example case https://react-dnd.github.io/react-dnd/examples-drag-around-naive.html - I did fix the issue with the pull request I submitted yesterday. Perhaps you could try and report back whether it solves your case as well. |
Still having issues on FF 57.0.1 on Ubuntu 16.04. I'm not able to drag & drop at all, seems like the drag event starts but cancels immediately afterwards. Works fine in chrome. |
I also have problems with FF and OSX 10.13.1 Edit: I found another issue similar to this one (#778). Check it for more details. Also tried the beta FF Nightly(https://nightly.mozilla.org/) and the bugs are gone. Maybe this is FF issue and not react-dnd. |
I'm still experiencing the problems in Nightly, but it seems to break a whole lot more in the app than just RDandD. So not sure I trust that as an indication if FF is the real cause of the bug, and if they have fixed it. |
@erwinverdonk , could you share your fix ? what was the PR? |
@Paddy-Hamilton yes with FF Nightly still some bugs appears. Working with chrome and safari like a charm so should be FF issue. My case is exact the one in the reported FF issue. |
@Paddy-Hamilton: Yeah I see it did not auto link here, so here is the link to PR: #928 |
So does anyone know what is the issue? |
…lace 'this' with '_' mistake and add type
… drag has ended
… 'mousemove' event listener delay
…newer Firefox versions and potential other browsers as well
…will be added at the correct time
Hi, I've found some sort of workaround that worked for me. My drag-n-drop worked fine in Chrome but didn't work in FF at all. |
The issue was still their for me in FF Nightly so I had to look for alternatives, I came across react-beautiful-dnd and it works like a charm in FF as well as all other major browsers, and has less markup than react-dnd which is a bonus. |
The Chess example still does not work in FF 59.0.2 |
The chess tutorial does not work on Linux with FF 60.0:
Expected results: the square is highlighted red Also: no matter what square my cursor is on, releasing the mouse cancels the drag. |
Ae you on Linux @adamhooper? I can't reproduce in OSX |
Fedora 28 |
I was hoping that installing today's 3.0.2 update would fix it. Unfortunately, it is still broken. I have only tested on Linux, however. Has anyone tried the example on a different operating system? |
The 3.x updates have been mainly targeted at improving types. I don't have a Linux machine, but if someone can reproduce this and cut a PR, that would be great |
I'm going to look into different cross-browser testing tools we can use to catch issues like this. The existing examples should be a pretty good baseline for tests. |
I can confirm I've only seen this problem on the Linux version of Firefox. Works fine on Windows. |
If you look at the Using |
Got it, that makes sense. so it's probably something to do with the goofy
settimeouts that were intended just for Firefox. If I cut a branch with a
proposed fix, would you be willing to npm link it and test it on Linux?
…On Tue, Jun 5, 2018, 5:10 AM Kyriakos Z. ***@***.***> wrote:
If you look at the sortable examples simple doesn't work, but stress test
works.
The difference is that stress test is updating the state inside a
requestAnimationFrame.
Using requestAnimationFrame solves it for me.
Firefox on Linux.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#869 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG7iExIfA_El7IoR80oWgIvo87n2ABBks5t5nVFgaJpZM4PPxNf>
.
|
@darthtrevino yeah of course! |
I just ran into a similar issue. What was causing my issue was that my drag handler (component with I don't know why it was causing the issue but as soon as I put it outside the Posting here in case it helps someone |
I've got the same issue in Firefox 60.8.0esr on Debian 10. Updating the state inside |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please do not close this. It is still broken in Firefox 60.9.0esr. |
@SystemParadox What OS are you using? |
Linux (Debian 10). I haven't had chance to try it on Windows yet but it seem very strange for it to be different. |
Fedora 30 |
If they broke it in 70.0a1 then it would seem this keeps breaking for some reason, which is a bit concerning. If it breaks again then we really need to create a bare minimum test case and submit a ticket to the firefox devs. |
It's 2021 and chess example still does not work. |
I haven't had time to dig into a triage here, although I can confirm this is a case in Windows as well with FF 92. PRs are welcome. Edit: looks fine running locally, there may have been a transient dependency update that fixed this |
This fixes a bug where the cards were not sortable in firefox due to a drag and drop bug. The ref for the drag item needs to be on the top level component apparently. react-dnd/react-dnd#869 (comment)
For anyone who is still experiencing this issue, i found that on firefox, using a button with the ref drag will not work sadly. Not exactly sure why this is the case but i avoided the issue by just replacing the button with a div and remove the button element. |
Hello,
reactdnd is not working anymore in the latest Firefox-Version 55.0.3
Using reactdnd version:
"react-dnd": "^2.5.1",
"react-dnd-html5-backend": "^2.5.1",
Does anyone knows the latest version of reactdnd where Firefox is working?
The text was updated successfully, but these errors were encountered: