Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to dropEffect for dropTarget #1125

Closed
user1736 opened this issue Aug 27, 2018 · 3 comments
Closed

Add access to dropEffect for dropTarget #1125

user1736 opened this issue Aug 27, 2018 · 3 comments
Labels

Comments

@user1736
Copy link

Hi there!

Is your feature request related to a problem? Please describe.
I'd like to have an access to the current drop effect in canDrop method within dropTarget decorator spec, so I could disable/enable drop targets according to current effect.

Describe the solution you'd like
I think it'll be nice to have an access to dropEffect from monitor. I prepared draft solution for version 3.0.2 here and don't mind adding this feature to newer versions of the library if needed.

It might be useful in #974 as well

@user1736
Copy link
Author

Up! Any comments on that? At least could you please triage it.

@stale
Copy link

stale bot commented Jul 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 6, 2019
@stale stale bot closed this as completed Jul 13, 2019
@willurmston
Copy link

This feature would be super helpful to me. I need to know if the dropped item was moved or copied from within the DropTarget, but from what I've read, you can only access the dropEffect in the DragSource. I have many DropTargets that all lead to different places, so I prefer to handle the onDrop logic in the DropTarget. Maybe I'm using the library incorrectly, but this seems like a valid use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants