Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to support month/year range pickers? #2221

Open
razlani opened this issue Nov 7, 2022 · 6 comments
Open

Any plan to support month/year range pickers? #2221

razlani opened this issue Nov 7, 2022 · 6 comments
Labels
feature request I want a new feature in react-dates! pull request wanted This is a great way to contribute! Help us out :-D

Comments

@razlani
Copy link

razlani commented Nov 7, 2022

We're thinking about using this otherwise wonderful lib but was wondering if there's any appetite to support month range picker for example, assuming you don't already?

@ljharb
Copy link
Member

ljharb commented Nov 7, 2022

That seems reasonable, altho it might require some complex design.

@ljharb ljharb added pull request wanted This is a great way to contribute! Help us out :-D feature request I want a new feature in react-dates! labels Nov 7, 2022
@razlani
Copy link
Author

razlani commented Nov 8, 2022

That seems reasonable, altho it might require some complex design.

Hey mate, I might consider contributing in that vein, will look into the effort required there.

In the mean time just wondering how come there hasn't been a release in a couple years or so?

Just wanted to ensure we could use the feature if it gets merged!

@ljharb
Copy link
Member

ljharb commented Nov 13, 2022

The project went unmaintained for awhile before being spun out to the community early this year, and since taking over, I haven't yet had time to cut an updated release. I hope to do so soon.

@nandita1
Copy link

nandita1 commented Dec 5, 2022

Hey @ljharb, we wanted the capability for month range picker. Can you give an estimate of the effort that might be required in this and if you can ensure that my PR gets merged if I raise one?
@razlani are you working on this?

@ljharb
Copy link
Member

ljharb commented Dec 15, 2022

@nandita1 the effort required is pretty high; in particular because it needs lots of design attention.

Also, hopefully soon, the Temporal proposal will stop making normative changes, and at that time, the entire project will be refactored from moment to Temporal - so it's probably best to wait until after that's done to try to build new components.

@razlani
Copy link
Author

razlani commented Dec 16, 2022

Hey @ljharb, we wanted the capability for month range picker. Can you give an estimate of the effort that might be required in this and if you can ensure that my PR gets merged if I raise one? @razlani are you working on this?

Running the repo itself was a mission on windows when I attempted to leverage this gorgeous lib. I built mine from scratch for month/year range pickers.

Also releases have been stale but @nandita1 seems to address that perhaps, with the upcoming changes?

Happy to swing back (with wsl to run the thing) and talk integrations at that time though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request I want a new feature in react-dates! pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Development

No branches or pull requests

3 participants