Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard shortcuts panel toggle button not appearing on Google Chrome #2220

Open
MarkKD opened this issue Oct 12, 2022 · 0 comments
Open

keyboard shortcuts panel toggle button not appearing on Google Chrome #2220

MarkKD opened this issue Oct 12, 2022 · 0 comments
Labels
bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D

Comments

@MarkKD
Copy link

MarkKD commented Oct 12, 2022

react-dates version
react-dates@21.8.3

Describe the bug
On the Google Chrome browser if the DayPicker has the withPortal set to true and the orientation set to vertical when the DayPicker is opened on a tablet-sized screen the keyboard shortcuts panel toggle button (right bottom corner triangle with a question mark) and the shortcuts panel will not appear and both are completely removed from the DOM.

Once this bug has occurred and the keyboard shortcuts button and panel will no longer appear even with page reloads, changing to desktop screen size, or clearing all storage types and cookies.

This appears to be similar to this issue raised in 2019 #1706

Source code (including props configuration)
Steps to reproduce the behavior:

 <DayPickerRangeController
            numberOfMonths={2}
            startDate={startDate}
            endDate={endDate}
            focusedInput={focusedInput}
            onFocusChange={(focused) => setFocusedInput(focused || 'endDate')}
            initialVisibleMonth={null}
            onDatesChange={handleDatesChange}
            orientation={ 'vertical' }
            withPortal={true}
            minimumNights={0}
          />

If you have custom methods that you are passing into a react-dates component, e.g. onDatesChange, onFocusChange, renderMonth, isDayBlocked, etc., please include the source for those as well.

Desktop (please complete the following information):

  • OS: [MAC OS, Windows]
  • Browser [chrome]

Is the issue reproducible in Storybook?
Please link to the relevant storybook example

@ljharb ljharb added bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oh no, something's broken :-( pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Development

No branches or pull requests

2 participants