Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off screen rendering for SEO #912

Open
jps opened this issue Jan 22, 2021 · 0 comments
Open

Off screen rendering for SEO #912

jps opened this issue Jan 22, 2021 · 0 comments

Comments

@jps
Copy link

jps commented Jan 22, 2021

Is your feature request related to a problem? Please describe

We are looking at integrating this library into our design system. We would like to use the modal to build a drawer component, similar to this, after all, it's essentially a modal docked to the side of the screen.

One requirement of our organisation, is we get good SEO, the DOM of the drawer needs to be readable by a bots which may or may not actually end up invoking it. This is especially important as it's conceivable the drawer would be used for building navigation on mobile screens.

Looking at base web they have a renderAll prop

image

I've had a look at your codebase, and from what I can see this isn't possible, but pardon my nativity if it is!

Describe the solution you'd like

The modal to render to the DOM but as display:none if a renderAll prop is supplied

Describe alternatives you've considered

We will wrap the modal inside our own component then export, so we could technically have it always open and hide with our own logic, the issue with this is we will lose out on transition and focus logic contained in your implementation. So there is actually little point in us using it if we need to do this 🤔.

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant