Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing aria-haspopup #855

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

romans12
Copy link

@romans12 romans12 commented Aug 19, 2020

Resolves #854

@jquense
Copy link
Member

jquense commented Aug 19, 2020

should we conditionally add it for cases where the menu is actually a role=menu? We do some of that already, it may not be too much extra work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DropdownToggle has the incorrect aria attribute of aria-haspopup
2 participants