Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license file in NPM distribution #50

Open
char0n opened this issue Oct 9, 2018 · 4 comments
Open

Missing license file in NPM distribution #50

char0n opened this issue Oct 9, 2018 · 4 comments

Comments

@char0n
Copy link

char0n commented Oct 9, 2018

Hello, is it possible to incorporate the LICENSE file inside the npm package ? Now it's missing. It's implied by MIT license that if licensed under the MIT the source code must be accompanied by full license text. If the license file is not in the npm package a lot of people cannot use it because it's a proprietary code at that point. Patch release with containing a LICENSE file will fix this.

Thank you very much

@taion
Copy link
Member

taion commented Oct 9, 2018

We'd welcome a PR for this.

@char0n
Copy link
Author

char0n commented Oct 9, 2018

There should be no need for PR. If you're using at least npm@5.6 it will always include the license inside the bundle, and there is now way how to tell npm no to do so.

@taion
Copy link
Member

taion commented Oct 9, 2018

We publish from the lib/ subdirectory to offer cleaner imports. We do not currently copy LICENSE into that directory before publishing.

@char0n
Copy link
Author

char0n commented Oct 10, 2018

Ok get it, I'll provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants