Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Email notification still sent even without test failures #419

Open
FrankTub opened this issue Jan 16, 2024 · 0 comments
Open

[BUG] Email notification still sent even without test failures #419

FrankTub opened this issue Jan 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@FrankTub
Copy link
Contributor

Describe the bug

We use re_data to alert specific data quality issues through email. These issues are dbt tests that we have declared and on that model we have assigned a re_data_owner. In case there is an issue with data the alert is send as expected.

Our script to run an alert is something like:

re_data notify email --start-date `date +%F` --end-date `date +%F` --select test --target "$TARGET" --no-send-all-good

Since we use the --no-send-all-good we would expect that in case there is no data quality issue, there will not be sent any email for that owner. The behavior we see is that these owners will receive an email without any test failures.

Expected behavior

In case there is no data quality issue for a re_data_owner, then we don't want to send an email.

To Reproduce

  1. Create a very simple dbt project with one model.
  2. Configure a single owner as re_data_owner. Make sure this owner does not own any other model.
  3. Create a test on this model that will never fail (e.g. - dbt_utils.expression_is_true: expression: "1=1", make sure to have not any other tests on this model.
  4. Configure re_data email setup
  5. Run something like following code:
dbt run --select <your_model>
dbt run --select package:re_data 
dbt test --select <your_model>
re_data overview generate
re_data notify email --start-date `date +%F` --end-date `date +%F` --select test --no-send-all-good

Receive empty mail.

Screenshots

Screenshot 2024-01-16 at 07 56 36

Logs and additional context

If needed please specify which log file you need and I will try to create it.

@FrankTub FrankTub added the bug Something isn't working label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant