Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] test reports as success when wrong metric is set #395

Open
bachng2017 opened this issue Mar 26, 2023 · 0 comments
Open

[BUG] test reports as success when wrong metric is set #395

bachng2017 opened this issue Mar 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bachng2017
Copy link
Contributor

bachng2017 commented Mar 26, 2023

Describe the bug
With current implement, when user set a wrong metric (type-missed or any reason), the test always succeed
https://github.com/re-data/dbt-re-data/blob/main/macros/tests/test_metrics.sql#L6

Although it might be by-design feature but reporting the situation as a failure might be more intuitive.

Expected behavior
Report the test as failure when wrong metric is set.

To Reproduce
Run a test with not-existed. For example row_countx instead row_count

Screenshots
Logs and additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant