Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Tanimoto Similarity Search in the rdkit/rdkit-js like RDKIT #293

Open
caok2709 opened this issue Jan 9, 2023 · 5 comments
Open

Need Tanimoto Similarity Search in the rdkit/rdkit-js like RDKIT #293

caok2709 opened this issue Jan 9, 2023 · 5 comments

Comments

@caok2709
Copy link

caok2709 commented Jan 9, 2023

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Right now, it looks like rdkit-js only have the ability to do the Substructure Search.

However, we need to have Tanimoto Similarity search. For example:
You send a smiles string/or rdkit.get_mol(smiles string) + the similarity level (like 80% or any similarity level you want), then the code will search through an array of smiles just like what Substructure Search did. Then the function will tell if it can reach the similarity level of not.

Describe alternatives you've considered
I reviewed the source code of RDKIT. It looks the function is already there: DataStructs.TanimotoSimilarity.
Will you be able to migrate the function and put it in the rdkit-js?

Additional context
None.

@caok2709 caok2709 changed the title Need Tanimoto Similarity function in the rdkit/rdkit-js like RDKIT Need Tanimoto Similarity Search in the rdkit/rdkit-js like RDKIT Jan 9, 2023
@caok2709
Copy link
Author

caok2709 commented Jan 9, 2023

@MichelML Happy new year. Please let me know if this function can be release in the rdkit-js any soon.

@MichelML
Copy link
Collaborator

MichelML commented Jan 9, 2023

Thanks @caok2709 , @ptosco isn't this possible already with the SubstructLibrary? Happy to add an example if it is indeed possible.

@ptosco
Copy link

ptosco commented Jan 9, 2023

@MichelML It isn't. SubstructLibrary only retrieves molecule that contain the specified substructure, using pattern fingerprints as a pre-filter to improve performance. Currently rdkit-js has no functionality for similarity searches.

@caok2709
Copy link
Author

@ptosco @MichelML Will it be possible to add Tanimoto Similarity search functionality in the next version?

@MichelML
Copy link
Collaborator

@ptosco how complex would it be to include similarity search in the minimallib? It seems like a common use case and something we would use at our company as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants