Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded Blocks Overflow Viewport #84

Open
mjdanbury opened this issue Aug 3, 2022 · 4 comments
Open

Embedded Blocks Overflow Viewport #84

mjdanbury opened this issue Aug 3, 2022 · 4 comments

Comments

@mjdanbury
Copy link

I'm using the Bear theme and have noticed that whenever I embed a block it will spill out past the viewport width:

block-embeds

This presents a usability issue that's not present in vanilla roam:
vanilla

@rcvd
Copy link
Owner

rcvd commented Aug 3, 2022

Should be fixed now.

@mjdanbury
Copy link
Author

I think there's a mistake with the most recent commit. Seems to be trying to import scripts from a local port rather than the repo.
localhost

@rcvd
Copy link
Owner

rcvd commented Aug 3, 2022

Damn - I shouldn't try to fix things after 13 hours of work :)

Should be working now.

@mjdanbury
Copy link
Author

Its back up and running! Totally understandable :)

This is definitely much better!! Things look great on the mobile app and the dekstop app at large window widths. I still notice the issue at window widths between these two regime's (see here: https://drive.google.com/file/d/1n6q-OyQwNeHX9l2fedNJ-p-fyvkA2suT/view?usp=sharing). That said, it's definitely much less of a pain point now. I appreciate the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants