Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep DictMethodRunner? #21

Open
piehld opened this issue Apr 18, 2022 · 1 comment
Open

Keep DictMethodRunner? #21

piehld opened this issue Apr 18, 2022 · 1 comment
Assignees
@brindakv @piehld @chrstyan

Comments

@piehld
Copy link
Collaborator

piehld commented Apr 18, 2022

From what I can tell, the file DictMethodRunner.py in this repository is never used by our codebase, while the [nearly] identical file in py-mmcif is used instead. If this is really the case, should we delete the file in this repository?
@piehld
Copy link
Collaborator Author

piehld commented Apr 18, 2022

Update: one possible reason why it was also included in this repository is due to difficulty installing the py-mmcif package locally (i.e., having trouble running pip install -e . for py-mmcif), thus making debugging difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brindakv brindakv

@piehld piehld

@chrstyan chrstyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brindakv @piehld @chrstyan