Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused(?) PdbxLoaderWorker class #41

Open
piehld opened this issue Apr 18, 2022 · 1 comment
Open

Remove unused(?) PdbxLoaderWorker class #41

piehld opened this issue Apr 18, 2022 · 1 comment
Assignees

Comments

@piehld
Copy link
Collaborator

piehld commented Apr 18, 2022

The class PdbxLoaderWorker doesn't appear to be used anywhere in the RCSB codebase, whereas the partly redundant but more extensive class PdbxLoader is used.

It seems that the PdbxLoader class was created as a clone of PdbxLoaderWorker, and then further developed and used instead of the PdbxLoaderWorker class altogether. If this is really the case (testing and/or research needed), it would be good to remove the unused class from the PdbxLoader.py code, since it contains a lot of redundant code, wastes space, and leads to confusion in reviewing the code: https://github.com/rcsb/py-rcsb_db/blob/master/rcsb/db/mongo/PdbxLoader.py

@piehld
Copy link
Collaborator Author

piehld commented Apr 18, 2022

This is obviously a low priority, but should be relatively easy to resolve during the next merge/release, so just wanted to make a note of it here so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants