Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crash caused by newly started process while jtop is running #519

Merged
merged 1 commit into from May 8, 2024

Conversation

gztong
Copy link

@gztong gztong commented May 7, 2024

Fixes #499

@rbonghi
Copy link
Owner

rbonghi commented May 7, 2024

Hi @gztong

Thank you very much for your PR! I really appreciate any type of support :-)

Can you help me understand your fix? I see that you canceled the if condition on the processes table.
Have you tried jtop when there are no GPU processes running?

@gztong
Copy link
Author

gztong commented May 7, 2024

Hi @rbonghi ,
Thanks for getting back to me!

Can you help me understand your fix?

The fix simply adds the ProcessTable even IF there is no GPU process at first during the ALL object init.
So that while jtop is running, if a new GPU process starts, jtop can add it to the process table for drawing.

Have you tried jtop when there are no GPU processes running?

Yes, I did. In this case, the process table is simply empty. I don't see any issues.

@rbonghi
Copy link
Owner

rbonghi commented May 8, 2024

Thank you @gztong
I also noticed a similar call in another part of the code.
Let me merge on develop branch

@rbonghi rbonghi changed the base branch from master to develop May 8, 2024 13:32
@rbonghi rbonghi merged commit cd2a2df into rbonghi:develop May 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on start or during runtime
2 participants