Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -- instead of - for arguments? #68

Open
wookayin opened this issue Oct 18, 2021 · 1 comment
Open

Use -- instead of - for arguments? #68

wookayin opened this issue Oct 18, 2021 · 1 comment
Labels
feedback wanted Feedback wanted from the community

Comments

@wookayin
Copy link

I would want to use -- for arguments (which is more a conventional and standard way), for example:

:Flog --all

instead of

:Flog -all

The reason I want this is it is more compatible with raw git log command so I can have the same code for generating raw git command lines and :Flog commands.

So it'd be nice to have all arguments coming with double dashes. For backward compatibility we could keep the single-dash arguments. Any thoughts?

@wookayin wookayin changed the title Use -- instead of -? Use -- instead of - for arguments? Oct 18, 2021
@rbong
Copy link
Owner

rbong commented Oct 18, 2021

Flog uses a more similar argument format to builtin vim commands. Flog arguments are not shell arguments, they are arguments for a vim command. It translates any arguments that go to git log. Flog also doesn't aim for feature parity with git log arguments, some of the things a shell command does are difficult to do in vim.

That said if this issue gets support I would be willing to switch. This is just the ideas that went into how it works now.

Backwards compatibility may not be something I want to do, I don't want to maintain both forever. If it ends up being easy, though, I would support both until it becomes unfavorable.

@rbong rbong added the feedback wanted Feedback wanted from the community label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Feedback wanted from the community
Projects
None yet
Development

No branches or pull requests

2 participants