Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support open current commit in web page by vim-fugitive ":Gbrowse" just like "GV" #57

Open
linjiX opened this issue May 3, 2021 · 3 comments
Labels
unlikely to fix Issues which we are likely unable to fix

Comments

@linjiX
Copy link

linjiX commented May 3, 2021

gv.vim supports using shortcut gb to open the current commit in web by calling :Gbrowse of vim-fugitive.
Is that possible to add this feature to vim-flog?

@TamaMcGlinn
Copy link
Contributor

Brilliant idea; it's very easy, just add this to your vimrc:

augroup flog
  autocmd FileType floggraph nno <buffer> gb :<C-U>call flog#run_command("GBrowse %(h)")<CR>
augroup END

However, gb overwrites the current git bisect view option toggler. In my opinion this is fine because I am much more likely to use GBrowse than bisect.

@linjiX
Copy link
Author

linjiX commented May 3, 2021

Thanks for your fast reply~
And the command you offered is exactly what I want!

@rbong
Copy link
Owner

rbong commented May 3, 2021

I like gbrowse myself, but I don't think I'll add this by default if the solution is sufficient. I'm getting worried about poluting the keybindings and needing to resolve keybinding later with Fugitive if they add equivalent or conflicting keybindings, since I try to keep it fairly consistent. I'll leave this open though in case it becomes a better idea in the future, like if fugitive adds its own Gbrowse binding.

@rbong rbong added the unlikely to fix Issues which we are likely unable to fix label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unlikely to fix Issues which we are likely unable to fix
Projects
None yet
Development

No branches or pull requests

3 participants