Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening diff by <CR> on diff line when -path specified doesn't work #53

Open
faisal-shah opened this issue Apr 23, 2021 · 1 comment
Open

Opening diff by <CR> on diff line when -path specified doesn't work #53

faisal-shah opened this issue Apr 23, 2021 · 1 comment
Labels
fugitive Issues with Fugitive that we can't fix

Comments

@faisal-shah
Copy link

faisal-shah commented Apr 23, 2021 •
edited

See here for some context: tpope/vim-fugitive#1738

It seems that the pretty format that vim-flog uses is interfering with fugitive.vim's ability to interpret the diff line in a patch log. This happens when you open the patch log with <TAB> in the floggraph, and not <CR> .
@faisal-shah faisal-shah mentioned this issue Apr 23, 2021
Closed
@rbong
Copy link
Owner

rbong commented May 2, 2021

I'm leaving this open in case of a more advanced future version or replacement. This would be solved by reducing our reliance on Fugitive, similar to reducing reliance on git log like with #46 and #26

@rbong rbong added the fugitive Issues with Fugitive that we can't fix label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fugitive Issues with Fugitive that we can't fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore user pretty when generating diff patch log with <TAB> faisal-shah/vim-flog
2 participants
@rbong @faisal-shah