-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF export support ? #3
Comments
Although it would be nice to add native PDF support, I'm a little hesitant, given my prior experience as a maintainer of resume-cli. It's difficult to come up with a one-size-fits-all solution when it comes to PDFs, since there are many varables involved—page sizes, format options, theme support, browser rendering, etc—which are often reported back as issues. It would also significantly increase install size. For now, I suggest plugging Resumed with whatever solution works best for you. In fact, I usually print the HTML to PDF myself, as I like to play with all the page settings and see a live preview of the result. I'll keep this open to collect more feedback/ideas though, thanks! |
Playing around with a lot of different themes, I actually ended up on your side. Writing pdf-friendly css is not straightforward and has many drawbacks, and many theme maintainer don't care about it at all. I found that playing with the browser's pdf export options to be the best way to get a satisfying result. There still are some contexts where you'd want this feature though, for example if you need to run resumed in a CI or ssh environment - but even then, there probably are more practical utilities to do it. Keeping the issue open to community discussion is a good idea. |
@rbardini It would be great to have this "print the HTML to PDF" information in the readme. |
As shown in the example, pdf export is pretty straightforward with
puppeteer
. Considering that many themes do have some PDF export parameters (asresume-cli
allowed it), and that PDF is the de-facto standard to share your resume, I think this feature deserves first party support in a resume exporting tool.I am willing to open a pull request for this, if you'd like.
The text was updated successfully, but these errors were encountered: