Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upserting an Asset returns 500 on duplicate owners #188

Open
StewartJingga opened this issue Nov 23, 2022 · 0 comments
Open

Upserting an Asset returns 500 on duplicate owners #188

StewartJingga opened this issue Nov 23, 2022 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@StewartJingga
Copy link
Contributor

Describe the bug
When upserting an asset with duplicate owners, Compass returns 5xx with no clear error message.

Sample request payload

{
  "urn": "sample-urn",
  "owners": [
    {
      "uuid": "sample-uuid",
      "email": "john@doe.com"
    },
    {
      "uuid": "sample-uuid",
      "email": "john@doe.com"
    }
  ]
}

To Reproduce
Steps to reproduce the behavior:

  1. Upsert an Asset with duplicate owners as shown in the example above
  2. Get 5xx error

Expected behavior
When handling duplicate owners, Compass should handle it by either:

  1. Distinct the owner list and return no error
  2. Return 4xx error to indicate that the payload is invalid and let client fix it
@StewartJingga StewartJingga added bug Something isn't working help wanted Extra attention is needed labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant